Factory: fix versioning (null pull_request hid open issues)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
Richard ZinkandClaude Sonnet 5.5 committed 2026-11-17 06:19:03 +01:00
1 parent e66574b529
commit dd3dd48969
3 files changed
+13 -1

No files matched your search

+8
View File
@@ -3,6 +3,14 @@
All notable changes to CodeCraft. Versions follow [Semantic Versioning](https://semver.org/); All notable changes to CodeCraft. Versions follow [Semantic Versioning](https://semver.org/);
until 1.0, minor versions may contain breaking changes. until 1.0, minor versions may contain breaking changes.
## [Unreleased]
### Fixed
- **Factory versioning.** Open issues of the forge were never seen (Gitea sends `"pull_request": null`), so every
deliverable counted as the last of its milestone and raised the minor version. Now only the last open issue of a
milestone raises the minor version; all others raise the patch version.
## [v202611-00051] – 2026-11-16 ## [v202611-00051] – 2026-11-16
### Added ### Added
+1 -1
View File
@@ -540,7 +540,7 @@ impl Forge {
let a = v.as_array().cloned().unwrap_or_default(); let a = v.as_array().cloned().unwrap_or_default();
let n = a.len(); let n = a.len();
for i in a { for i in a {
if i.get("pull_request").is_some() { if !i.get("pull_request").map_or(true, |p| p.is_null()) {
continue; continue;
} }
out.push((i[key].as_i64().unwrap_or(0), i["title"].as_str().unwrap_or("").to_string())); out.push((i[key].as_i64().unwrap_or(0), i["title"].as_str().unwrap_or("").to_string()));
+4
View File
@@ -3,6 +3,10 @@
* under "unreleased"; scripts/release.sh renames the key to the release version. * under "unreleased"; scripts/release.sh renames the key to the release version.
*/ */
export const WHATS_NEW: Record<string, { en: string[]; de: string[] }> = { export const WHATS_NEW: Record<string, { en: string[]; de: string[] }> = {
unreleased: {
en: ["Factory: fixed versioning – deliverables raise the patch version, only the last one of a milestone raises the minor version"],
de: ["Factory: Versionierung korrigiert – Deliverables erhöhen die Patch-Version, nur das letzte eines Meilensteins die Minor-Version"],
},
"202611-00051": { "202611-00051": {
en: ["Factory: close finished issues with a comment; the Done column moved to the right"], en: ["Factory: close finished issues with a comment; the Done column moved to the right"],
de: ["Factory: fertige Issues mit Kommentar schließen; die Spalte Fertig steht jetzt ganz rechts"], de: ["Factory: fertige Issues mit Kommentar schließen; die Spalte Fertig steht jetzt ganz rechts"],